Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luxtorpeda DOES require one dependency when building from source. #44

Closed
wants to merge 1 commit into from
Closed

Luxtorpeda DOES require one dependency when building from source. #44

wants to merge 1 commit into from

Conversation

PoorPocketsMcNewHold
Copy link
Contributor

@PoorPocketsMcNewHold PoorPocketsMcNewHold commented Oct 3, 2019

I´ve had to install libssl-dev due to that.

To be fair, I´m using deepin 15.11, which has it´s own debian repo, but is usually more outdated, so it this might be preinstalled on more ¨updated¨ distros like those.
I wasn´t sure if the package name was the exact one on OpenSUSE and Manjaro/Arch so i didn´t added those.

If this sound more of an issue, I´ll open one for it if needed.

```bash
pm@Velvet4Renaissance:~/luxtorpeda$ make user-install
cargo build
   Compiling openssl-sys v0.9.48
   Compiling idna v0.1.5
   Compiling rand_chacha v0.1.1
   Compiling backtrace-sys v0.1.31
   Compiling miniz_oxide_c_api v0.2.3
   Compiling lzma-sys v0.1.15
   Compiling parking_lot_core v0.4.0
   Compiling bytes v0.4.12
   Compiling mio v0.6.19
   Compiling hyper v0.12.33
error: failed to run custom build command for `openssl-sys v0.9.48`

Caused by:
  process didn't exit successfully: `/home/pm/luxtorpeda/target/debug/build/openssl-sys-93434b38d6dc981f/build-script-main` (exit code: 101)
--- stdout
cargo:rustc-cfg=const_fn
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
run pkg_config fail: "`\"pkg-config\" \"--libs\" \"--cflags\" \"openssl\"` did not exit successfully: exit code: 1\n--- stderr\nPackage openssl was not found in the pkg-config search path.\nPerhaps you should add the directory containing `openssl.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'openssl\' found\n"

--- stderr
thread 'main' panicked at '

Could not find directory of OpenSSL installation, and this `-sys` crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
compilation process.

Make sure you also have the development packages of openssl installed.
For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

If you're in a situation where you think the directory *should* be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.

$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.48

', /home/pm/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-sys-0.9.48/build/find_normal.rs:150:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed
Makefile:37 : la recette pour la cible « build » a échouée
make: *** [build] Erreur 101
```

To be fair, I´m using deepin 15.11, which has it´s own debian repo, but is usually more outdated, so it this might be preinstalled on more ¨updated¨ distros like those.
I wasn´t sure if the package name was the exact one on OpenSUSE and Manjaro/Arch so i didn´t added those.

If this sound more of an issue, I´ll open one for it if needed.
@PoorPocketsMcNewHold
Copy link
Contributor Author

PoorPocketsMcNewHold commented Oct 3, 2019

pm@Velvet4Renaissance:~/luxtorpeda$ make user-install
cargo build
   Compiling openssl-sys v0.9.48
   Compiling idna v0.1.5
   Compiling rand_chacha v0.1.1
   Compiling backtrace-sys v0.1.31
   Compiling miniz_oxide_c_api v0.2.3
   Compiling lzma-sys v0.1.15
   Compiling parking_lot_core v0.4.0
   Compiling bytes v0.4.12
   Compiling mio v0.6.19
   Compiling hyper v0.12.33
error: failed to run custom build command for `openssl-sys v0.9.48`

Caused by:
  process didn't exit successfully: `/home/pm/luxtorpeda/target/debug/build/openssl-sys-93434b38d6dc981f/build-script-main` (exit code: 101)
--- stdout
cargo:rustc-cfg=const_fn
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
run pkg_config fail: "`\"pkg-config\" \"--libs\" \"--cflags\" \"openssl\"` did not exit successfully: exit code: 1\n--- stderr\nPackage openssl was not found in the pkg-config search path.\nPerhaps you should add the directory containing `openssl.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'openssl\' found\n"

--- stderr
thread 'main' panicked at '

Could not find directory of OpenSSL installation, and this `-sys` crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
compilation process.

Make sure you also have the development packages of openssl installed.
For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

If you're in a situation where you think the directory *should* be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.

$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.48

', /home/pm/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-sys-0.9.48/build/find_normal.rs:150:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed
Makefile:37 : la recette pour la cible « build » a échouée
make: *** [build] Erreur 101
pm@Velvet4Renaissance:~/luxtorpeda$ sudo apt install libssl-dev
Lecture des listes de paquets... Fait
Construction de l'arbre des dépendances       
Lecture des informations d'état... Fait
The following additional packages will be installed:
  libssl-doc
Les NOUVEAUX paquets suivants seront installés :
  libssl-dev libssl-doc
0 mis à jour, 2 nouvellement installés, 0 à enlever et 1 non mis à jour.
Il est nécessaire de prendre 3 064 ko dans les archives.
Après cette opération, 11,8 Mo d'espace disque supplémentaires seront utilisés.
Souhaitez-vous continuer ? [O/n] O
Réception de:1 http://packages.deepin.com/deepin lion/main amd64 libssl-dev amd64 1.1.0j-1~deb9u1 [1 588 kB]
Réception de:2 http://packages.deepin.com/deepin lion/main amd64 libssl-doc all 1.1.0j-1~deb9u1 [1 476 kB]
3 064 ko réceptionnés en 3s (806 ko/s)  
dpkg: avertissement: analyse du fichier '/var/lib/dpkg/status' vers la ligne 25354 paquet 'green-tunnel' :
  maintainer manque 
Sélection du paquet libssl-dev:amd64 précédemment désélectionné.
(Lecture de la base de données... 269949 fichiers et répertoires déjà installés.)
Préparation du dépaquetage de .../libssl-dev_1.1.0j-1~deb9u1_amd64.deb ...
Dépaquetage de libssl-dev:amd64 (1.1.0j-1~deb9u1) ...
Sélection du paquet libssl-doc précédemment désélectionné.
Préparation du dépaquetage de .../libssl-doc_1.1.0j-1~deb9u1_all.deb ...
Dépaquetage de libssl-doc (1.1.0j-1~deb9u1) ...
dpkg: avertissement: analyse du fichier '/var/lib/dpkg/status' vers la ligne 25376 paquet 'green-tunnel' :
  maintainer manque 
Paramétrage de libssl-dev:amd64 (1.1.0j-1~deb9u1) ...
Traitement des actions différées (« triggers ») pour man-db (2.7.6.1-2) ...
Paramétrage de libssl-doc (1.1.0j-1~deb9u1) ...
pm@Velvet4Renaissance:~/luxtorpeda$ make user-install
cargo build
   Compiling openssl-sys v0.9.48
   Compiling url v1.7.2
   Compiling rand v0.6.5
   Compiling futures-cpupool v0.1.8
   Compiling tar v0.4.26
   Compiling crossbeam-deque v0.7.1
   Compiling phf_shared v0.7.24
   Compiling syn v0.15.42
   Compiling tokio-timer v0.2.11
   Compiling tokio-current-thread v0.1.6
   Compiling backtrace v0.3.33
   Compiling regex v1.2.0
   Compiling mime v0.3.13
   Compiling flate2 v1.0.9
   Compiling xz2 v0.1.6
   Compiling tokio-io v0.1.12
   Compiling mio-uds v0.6.7
   Compiling string v0.2.1
   Compiling tokio-buf v0.1.1
   Compiling http v0.1.17
   Compiling openssl v0.10.24
   Compiling native-tls v0.2.3
   Compiling phf v0.7.24
   Compiling error-chain v0.12.1
   Compiling cookie v0.12.0
   Compiling parking_lot_core v0.4.0
   Compiling phf_generator v0.7.24
   Compiling tokio-threadpool v0.1.15
   Compiling uuid v0.7.4
   Compiling tokio-codec v0.1.1
   Compiling phf_codegen v0.7.24
   Compiling publicsuffix v1.5.2
   Compiling parking_lot v0.7.1
   Compiling mime_guess v2.0.0-alpha.6
   Compiling tokio-fs v0.1.6
   Compiling tokio-reactor v0.1.9
   Compiling synstructure v0.10.2
   Compiling h2 v0.1.25
   Compiling http-body v0.1.0
   Compiling tokio-tcp v0.1.3
   Compiling tokio-udp v0.1.3
   Compiling tokio-uds v0.2.5
   Compiling tokio v0.1.22
   Compiling inotify v0.7.0
   Compiling serde_derive v1.0.97
   Compiling failure_derive v0.1.5
   Compiling hyper v0.12.33
   Compiling failure v0.1.5
   Compiling hyper-tls v0.3.2
   Compiling serde v1.0.97
   Compiling serde_json v1.0.40
   Compiling serde_urlencoded v0.5.5
   Compiling serde_regex v0.4.0
   Compiling cookie_store v0.7.0
   Compiling reqwest v0.9.19
   Compiling luxtorpeda v0.1.0 (/home/pm/luxtorpeda)
    Finished dev [unoptimized + debuginfo] target(s) in 37.68s
sed 's/%name%/luxtorpeda_dev/; s/%display_name%/Luxtorpeda (dev)/' compatibilitytool.template > target/debug/compatibilitytool.vdf
cp --reflink=auto toolmanifest.vdf target/debug/toolmanifest.vdf
cp --reflink=auto packages.json target/debug/packages.json
cp --reflink=auto LICENSE target/debug/LICENSE
cp --reflink=auto README.md target/debug/README.md
mkdir -p /home/pm/.local/share/Steam/compatibilitytools.d/luxtorpeda-dev
cd target/debug && cp --reflink=auto -t /home/pm/.local/share/Steam/compatibilitytools.d/luxtorpeda-dev compatibilitytool.vdf toolmanifest.vdf packages.json luxtorpeda LICENSE README.md
pm@Velvet4Renaissance:~/luxtorpeda$ 

Here the complete log, including, in order, the fail build log, the installation of the requested dependency, and the completed build after that.

@dreamer
Copy link
Owner

dreamer commented Oct 3, 2019

Thanks for pointing this out. This bug is already tracked in #42

I'm ok with merging the README update, but amend the commit and remove compilation log from commit message - it will cause issues for me when using git log --grep in future.

@PoorPocketsMcNewHold
Copy link
Contributor Author

Done. (If i´ve particurlary understood what ammending a commit is).

@dreamer dreamer closed this in e770a4f Oct 3, 2019
@dreamer
Copy link
Owner

dreamer commented Oct 3, 2019

Done, thank you for the change :)

You missed the mark with amend, I think (no worries, I did it on my side). You can read more about amending here: https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend

It basically replaces the last commit in your local branch (and gives you a chance to rewrite commit message). To make amended commit appear in the GitHub's PR you need to force-push to the branch that you are trying to merge (it will make the review automatically updated).

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants