Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual select 1.0.43 #692

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

MichalLauer
Copy link
Contributor

Hello,

this PR only updates the virtual select dependency to 1.0.43 because of sa-si-dev/virtual-select#319.

Not sure if anything else is needed - if so, feel free to let me know :)

Thanks!

@pvictor pvictor merged commit 6e57325 into dreamRs:master Apr 24, 2024
7 checks passed
@pvictor
Copy link
Member

pvictor commented Apr 24, 2024

Thanks,

If you want to try the new version of virtual-select, you need to install npm, then run :

packer::npm_install()
packer::bundle()

to install all npm package in package.json and then update the bundle containing virtual-select lib and bindings.

I added a note in the readme : https://github.com/dreamRs/shinyWidgets#development

@MichalLauer MichalLauer deleted the virtual-select-1.0.43 branch April 24, 2024 13:10
@MichalLauer
Copy link
Contributor Author

Hello,

thanks! I will try that. Should I create another PR to push the new bundle?

@pvictor
Copy link
Member

pvictor commented Apr 24, 2024

I've pushed the new bundle, if you re-install from GitHub you will have virtual-select 1.0.43.
But next time you can try that if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants