Skip to content

feat(facade): make facade a separate pacakge #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2024
Merged

feat(facade): make facade a separate pacakge #964

merged 4 commits into from
Jan 2, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 2, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #960

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e40bb28) 24.41% compared to head (831ffc6) 0.00%.
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/facade/src/apis/facade.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #964       +/-   ##
==========================================
- Coverage   24.41%   0.00%   -24.42%     
==========================================
  Files         101       5       -96     
  Lines        5915      84     -5831     
  Branches     1156       7     -1149     
==========================================
- Hits         1444       0     -1444     
+ Misses       4471      79     -4392     
- Partials        0       5        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit e473dbf into dev Jan 2, 2024
@wzhudev wzhudev deleted the wzhudev/facade branch January 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add a facade package as a simpler way of using Univer
2 participants