Skip to content

docs: update readme #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

docs: update readme #953

merged 1 commit into from
Jan 2, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jan 2, 2024

  • I am sure that the code is update-to-date with the dev branch.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4c4913b) 20.43% compared to head (a8b709c) 27.62%.
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/engine-render/src/context.ts 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #953      +/-   ##
==========================================
+ Coverage   20.43%   27.62%   +7.18%     
==========================================
  Files         198      736     +538     
  Lines       11499    43337   +31838     
  Branches     2305     8837    +6532     
==========================================
+ Hits         2350    11970    +9620     
- Misses       7855    27471   +19616     
- Partials     1294     3896    +2602

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

wzhudev
wzhudev reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit e91070d into dev Jan 2, 2024
@jikkai jikkai deleted the docs/readme branch January 2, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev left review comments

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jikkai @wzhudev