Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fixed the effect of filters on SUBTOTAL formula calcula… #4845

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

wpxp123456
Copy link
Contributor

…tion

close #4816

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Mar 17, 2025

Playwright test results

passed  25 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 9 seconds
commit  bb06e4f
info  For more information, see full report

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (2901d30) to head (bb06e4f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ngine-formula/src/functions/math/subtotal/index.ts 72.72% 3 Missing ⚠️
...formula/src/services/sheet-row-filtered.service.ts 57.14% 3 Missing ⚠️
...ngine-formula/src/services/current-data.service.ts 87.50% 1 Missing ⚠️
...ilter/src/services/sheet-filter-formula.service.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4845      +/-   ##
==========================================
+ Coverage   34.11%   34.12%   +0.01%     
==========================================
  Files        2625     2626       +1     
  Lines      136922   136961      +39     
  Branches    30403    30410       +7     
==========================================
+ Hits        46711    46742      +31     
- Misses      90211    90219       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current change violates our architecture design.

@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Mar 17, 2025
@wpxp123456 wpxp123456 merged commit 361991e into dev Mar 17, 2025
9 checks passed
@wpxp123456 wpxp123456 deleted the pxp/03171150 branch March 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SUBTOTAL function problem
2 participants