Fix processing additionalProperties when bool-type#288
Open
Matthijsy wants to merge 2 commits intodreadnode:mainfrom
Open
Fix processing additionalProperties when bool-type#288Matthijsy wants to merge 2 commits intodreadnode:mainfrom
Matthijsy wants to merge 2 commits intodreadnode:mainfrom
Conversation
Contributor
|
Thanks for catching this bug and providing the fix! The One thing to consider: according to JSON Schema spec, Your current fix prevents the crash but causes Here's a more complete fix: if additional_schema:
if additional_schema is True:
return dict[str, t.Any], field_info
elif isinstance(additional_schema, dict):
dict_type, _ = _process_field(f"{field_name}Item", additional_schema)
return dict[str, dict_type], field_infoThis way:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am just starting to use rigging, in combination with the fabric-rti-mcp. Using this crashed the
_process_fieldsince it returns a schema like this:This results in trying to process
Trueas a dict. This PR first checks if theadditionalPropertiesvalue actually is a dict before processing.Please let me know if there is any feedback.