Improve download throughput #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the download method limits the throughput at a maximum of 40 KB/s (due to chunk size and the sleep). The fix increases the chunk size so 16 KB, factors it out as a class member and remove the sleep in order to allow for maximum possible throughput
|
Would it be possible to get this merged and released @drdarshan ? |
|
I'd appreciate that too, working with large matrices is pretty impractical in the current state. And to a user it might not be immediately obvious that they are waiting because of artificially throttled download speed, took me a moment to realize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the download method limits the throughput at a maximum of 40 KB/s (due to chunk size and the sleep). The fix increases the chunk size so 16 KB, factors it out as a class member and remove the sleep in order to allow for maximum possible throughput