Streamline internal structure #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drborges
force-pushed
the
streamline-internal-structure
branch
from
e09f7ec to
62868d5
Compare
In retrospect, this is where it belongs, Arbor itself does not care how nodes are cloned, the engine is how we can configure it to be mutable vs immutable.
There are two points in the OST creation where a node needs to be seeded. 1) When traversing from a parent node to its child for the first time, where the child node needs to be created and cached. 2) when setting the root state of the store where the Path is empty. With that said, I think we may be able to change how we handle paths so that even the root node's seed is included in the path.
drborges
force-pushed
the
streamline-internal-structure
branch
from
28e62fc to
55b13c8
Compare
… API of Scoped nodes
drborges
force-pushed
the
streamline-internal-structure
branch
from
9f01836 to
d102574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and organize Arbor's internals to make it easier to navigate the codebase.