Fixing Dockerfile for podman too #583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Dockerfile, while absolutely fine, is too tightened to docker only.
You're assuming the default registry (docker.io) and the default namespace (library).
With a simple line modification you can have it working without issues with docker and podman too.
Many of us are not allowed to use docker for licensing issues (docker is not free) and others simply don't want to have it around because podman has different benefits (license, rootless, daemon free, ...).
As a CNCF suggestion it's also welcomed if you'd like to change the filename from
Dockerfile
toContainerfile
in the future which seems to be more permissive and friendly for other engines too (lxd, containerd, ...).