Fix: Always use gistId from URL for sharing, prevent duplicate gist creation #511
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, when opening a diagram via a share link (
?shareId=...
), thegistId
is not always set correctly in the app state. As a result, when the user tries to share again, a new gist is created instead of updating the existing one. This leads to unnecessary gist duplication and breaks the expected collaborative workflow.Solution:
gistId
from theshareId
URL parameter if present.gistId
.Code changes:
Workspace.jsx
, add auseEffect
to setgistId
from the URL on mount:Share.jsx
, use the currentgistId
for patching, and only create a new gist ifgistId
is empty:Result: