Fix to comments visualization in tables and fields popovers #33
Conversation
|
@santilapi13 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello! Thank for the contribution. I can't reproduce the overflow bug |
| </div> | ||
| } | ||
| position="right" | ||
| showArrow | ||
| style={{ width: "200px", wordBreak: "break-word" }} |
There was a problem hiding this comment.
This breaks the UI.
Consider removing the width size and adding a 'max-w-[{width}px]' to the comment rather than the whole popover
| <p> | ||
| <strong>Comment:</strong>{" "} | ||
| {e.comment === "" ? ( | ||
| "Not comment" |
There was a problem hiding this comment.
Replace "Not comment" with "No comment"
|
I've just committed suggested changes, but I don't know how to make the pull request again, nor if I have to do it 😅 The "overflow bug" happened with long but non-existent words, for example "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa".: Breaking words solves this problem: As you said, I changed the comment div style instead of the Popover style. I gave it a max width so that it grows to a certain point, but it also keeps small if there are only a few words. Now, the UI doesn't break any more. Finally, I also changed "Not comment" to "No comment". Here you have some pictures.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I saw issue #26 and I didn't catch what it was refering to (maybe some about bringing comments from SQL code?), but I found out a few bugs in comments display while you hover the mouse over tables and tables' fields.
wordBreak:"break-word"to the Popover's style property.This is not a big deal but it would be my first contribution ever, so I hope it helps.