-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved router to a separate folder for better code readability #214
Conversation
@tejasbenibagde is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! The theming is broken, can you check it out
theme-bug.mp4
ok I'm checking |
wait I tried to understand how you are manipulating the theme, and realized that you unnecessarily wrote too much code in many places just to switch into the light and dark theme and still it is not working, my question is that, if you are using tailwindcss then why did you not create a single separate hook to handle the dark and light mode state, one file(specifically a button) that helps you switch between dark and light theme, also you did not put the colors in the tailwindconfig for different themes, bro your life would have been thousand times easy if you have used the tailwindcss at it's full extent for this purpose. I would have helped you with this problem but I don't get too much time in a day, sorry bro |
@tejasbenibagde because I'm using a UI library that handles theming differently. I can't really control the theme of popovers with tailwind |
I'm not questioning your choices or the tools you're using; I just wanted to point out that it might have been easier to manage things like the dark/light toggle if Tailwind CSS had been used from the start for this purpose. It could have simplified the process by handling colors, fonts, themes, and more. |
That said, good luck with your project—it's a big one, and I’m sure it will turn out great! |
Thanks man! I appreciate the contribution |
No description provided.