Skip to content

Conversation

PeterDaveHello
Copy link
Contributor

🎉

Copy link

vercel bot commented Jul 28, 2024

@PeterDaveHello is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 7:08pm

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@1ilit 1ilit merged commit 2516bb1 into drawdb-io:main Jul 28, 2024
4 checks passed
@PeterDaveHello PeterDaveHello deleted the Add-zh-tw-locale branch July 29, 2024 13:06
@PeterDaveHello
Copy link
Contributor Author

Hi @1ilit,

Now, I can see Traditional Chinese on https://www.drawdb.app/editor, but maybe I've done something wrong. The result is Simplified Chinese, not Traditional Chinese. Could you give me some help, please? Many thanks.

image

@1ilit
Copy link
Member

1ilit commented Jul 29, 2024

@PeterDaveHello my bad for not catching it before merge.

The code in the traditionalChinese object has to be 'zh-TW' and the i18n object should map 'zh-TW' to zh_tw in resources like so:

i18n
  .use(LanguageDetector)
  .use(initReactI18next)
  .init({
    fallbackLng: "en",
    debug: false,
    interpolation: {
      escapeValue: false,
    },
    resources: {
      en,
      zh,
      es,
      da,
      de,
      vi,
      "pt-BR": pt,
      fa,
      hi,
      mr,
      uk,
      ru,
      tr,
      fr,
      pa,
      hy,
      ar,
      "zh-TW": zh_tw,
    },
  });

It has come to my attention that this will cause an issue for Portuguese as well.

Feel free to make a follow up PR fixing this if you're interested.

Again, sorry for the inconvenience.

PeterDaveHello added a commit to PeterDaveHello/drawdb that referenced this pull request Jul 29, 2024
PeterDaveHello added a commit to PeterDaveHello/drawdb that referenced this pull request Jul 29, 2024
@PeterDaveHello PeterDaveHello mentioned this pull request Jul 29, 2024
@PeterDaveHello
Copy link
Contributor Author

@1ilit no problem, PR #187 sent! Please take a look, thanks!

@PeterDaveHello
Copy link
Contributor Author

Now it works like a charm 💪
image

nokhalal-mahato pushed a commit to nokhalal-mahato/drawdb that referenced this pull request Aug 11, 2025
Add zh-tw Traditional Chinese translation
nokhalal-mahato pushed a commit to nokhalal-mahato/drawdb that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants