Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancelSubscription method #251

Open
wants to merge 1 commit into
base: 4.7-dev
Choose a base branch
from

Conversation

jitendrapurohit
Copy link
Contributor

@jitendrapurohit jitendrapurohit commented Apr 10, 2018

User gets below warning on the cancel recur subscription page

Automatic cancellation is not supported for this payment processor. You or the contributor will need to manually cancel this recurring contribution using the payment processor website.

Stripe supports the cancellation of subcription. This PR adds this functionality to the extension.

Testing can be done using the below steps -

  • Create a recur payment
  • Click the cancel URL from the mail and cancel the subscription. No warning shown on this page and it also cancels the subscription from stripe site.

@mattwire
Copy link
Contributor

ping @jmcclelland

@jmcclelland
Copy link
Contributor

I think this is an important feature!

And, I think this is a duplicate of of #240, which has a long conversation in the pull request. I think the other PR handles possible errors when canceling an already canceled subscription and also it uses the more modern API to update the subscription id.

I'm commenting on the other PR since it seems a bit more active with one more thought about an upgrade script...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants