Use public property, not private property.

[jmcclelland]

Avoids error - see
#218

[lolaslade]

We applied this and it seems to work well. We tested multiple backend pages as well as changing the processor a couple of times to to other processors and back to Stripe.

[herbdool]

@h-c-c I can confirm that, after testing this as well. It is working well on Civicrm 4.7.x

[laryn]

@lolaslade @herbdool Did you patch 4.7.3 or the latest head? I just tried to patch the latest, then cleared caches, and am still getting "Sorry we can't provide this at the moment" with the "Stripe.js token was not passed! Report this message to the site administrator." error on a back end credit card contribution entry.

[herbdool]

@laryn just looking into this now. We created a patch based on this PR plus mattwire@2016de7 and applied it to 4.7.3. Here's the actual patch: https://gist.github.com/herbdool/b26dcd73219692be100a08f4e18bec3b

If you can confirm this helps, I may help make it a combined PR to this project.

We also patched it with #252 so we could have 100% discounts.

[laryn]

Thanks @herbdool I just patched a site with the above and after some front end testing (donate page still functioning) asked them to test the backend credit card entry. Will let you know when I hear back!

[mattwire]

@laryn @herbdool The stripe extension has a bit of a history of whack-a-mole because you fix one thing and that breaks another. That's the reason for making so many changes in my branch to bring everything up to date and only support recent versions of CiviCRM (5.0+). There seem to be so many forks being maintained by various people because of this. @jmcclelland and I have been collaborating to merge our two forks together and add unit testing. My branch is the result of that.
In any case, a list of tests that would need to be run to make sure that nothing else breaks are here: https://github.com/mattwire/com.drastikbydesign.stripe#phpunit

[laryn]

@mattwire It would be awesome to get things ironed out and get a stable release. I have this installed on a variety of nonprofit sites that I help with and can't feel like I trust it exactly because of what you've described. One has issues with recurring if I change anything, one can't enter credit cards in the back end, etc. Thanks for your work towards that goal of stability!

[mattwire]

@laryn @jmcclelland has done loads of work on recurring in my branch, including using the core CiviCRM IPN classes (instead of a custom one), adding an API for testing and phpunit tests.

[laryn]

Sounds great. Are @h-c-c and @drastik involved as well, or on board with it?

[laryn]

@herbdool I just heard back from the group whose site I patched with your patch and backend contributions are now working for them.

[herbdool]

@laryn that's great! For now we may leave it as a patch to a specific release and wait for all the work on the branches to bear fruit.