unused codes fixes #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 8, 2016 22:21
IDK I might be breaking some of these tests. That is to say not failing but actually commenting them out. These files are way more confusing and complicated than I thought.
added 3 commits
December 9, 2016 11:57
1 failed 64 passed 3 pytest warnings 44 errored
|
So I don't think I'll end up merging this branch. Too many changes where made trying to satisfy codacy's insane demands and I think that that resulted in me accidentally breaking shit b/c I didn't know what I was doing. Mostly the tests I mean. More on all that in whatever my next PR is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.