Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associations: #decorate queries DB every time #932

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Associations: #decorate queries DB every time #932

merged 1 commit into from
Sep 13, 2024

Commits on Sep 7, 2024

  1. Associations: #decorate queries DB every time 

    `ActiveRecord::Associations::CollectionProxy#decorate` ignores `target`
(be it already loaded or not) and loads the association again every time
it's called.

That's why unsaved records get missing from the decorated collection.

Resolves drapergem#646,
         drapergem#706,
         drapergem#827.
    @Alexander-Senko
    Alexander-Senko committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    47ccabc View commit details
    Browse the repository at this point in the history