Port asset-preprocessing.js to TypeScript (#51382)

drakogang · Jun 25, 2024 · bc58017 · bc58017
1 parent 1318dcf
commit bc58017
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/assets/middleware/asset-preprocessing.js → src/assets/middleware/asset-preprocessing.ts b/src/assets/middleware/asset-preprocessing.js → src/assets/middleware/asset-preprocessing.ts
@@ -1,3 +1,7 @@
+import type { Response, NextFunction } from 'express'
+
+import type { ExtendedRequest } from '@/types'
+
 // This middleware rewrites the URL of requests that contain the
 // portion of `/cb-\d+/`.
 // "cb" stands for "cache bust".
@@ -10,7 +14,11 @@
 
 const regex = /\/cb-\d+\//
 
-export default function assetPreprocessing(req, res, next) {
+export default function assetPreprocessing(
+  req: ExtendedRequest,
+  res: Response,
+  next: NextFunction,
+) {
   if (req.path.startsWith('/assets/')) {
     // We didn't use to have a rule about all image assets must be
     // lower case. So we've exposed things like:

diff --git a/src/frame/middleware/index.ts b/src/frame/middleware/index.ts
@@ -52,7 +52,7 @@ import featuredLinks from '@/landings/middleware/featured-links.js'
 import learningTrack from '@/learning-track/middleware/learning-track.js'
 import next from './next.js'
 import renderPage from './render-page.js'
-import assetPreprocessing from '@/assets/middleware/asset-preprocessing.js'
+import assetPreprocessing from '@/assets/middleware/asset-preprocessing'
 import archivedAssetRedirects from '@/archives/middleware/archived-asset-redirects.js'
 import favicons from './favicons.js'
 import setStaticAssetCaching from '@/assets/middleware/static-asset-caching.js'