[Test] enhance hot upgrade test #1726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zephyrcf
requested review from
imeoer,
hsiangkao and
power-more
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
- Coverage 55.49% 55.46% -0.04%
==========================================
Files 197 197
Lines 53292 53292
Branches 44624 44624
==========================================
- Hits 29577 29561 -16
- Misses 22245 22260 +15
- Partials 1470 1471 +1 🚀 New features to boost your workflow:
|
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
from
a8749e3 to
b28689f
Compare
|
It seems that I need to confirm whether new nydusdPath exists. |
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
2 times, most recently
from
6108411 to
47a6c1a
Compare
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
4 times, most recently
from
823f858 to
48704f8
Compare
|
https://github.com/containerd/nydus-snapshotter/blob/d7924384acd9ba8418f9e6c3f25c74a9d83b55ed/pkg/system/system.go#L349 |
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
2 times, most recently
from
eb5b937 to
88b234a
Compare
imeoer
reviewed
Jul 30, 2025
|
Thanks, plz squash the commits. :) |
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
from
4632ace to
b3521d4
Compare
Signed-off-by: Zephyr <zinsist777@gmail.com> Enhance hot upgrade tests Signed-off-by: Zephyr <zinsist777@gmail.com> wrapping binary file permissions Signed-off-by: Zephyr <zinsist777@gmail.com> rollback chmod Signed-off-by: Zephyr <zinsist777@gmail.com> rollback chmod Signed-off-by: Zephyr <zinsist777@gmail.com> Enhance hot upgrade tests Signed-off-by: Zephyr <zinsist777@gmail.com> Enhance hot upgrade tests Signed-off-by: Zephyr <zinsist777@gmail.com>
Zephyrcf
force-pushed
the
test/enhance-hot-upgrade-test
branch
from
b3521d4 to
19f613f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue
#1698
Details
Adds Snapshotter Restart Recovery Tests : Introduces a dedicated test case to validate
nydus-snapshotter's ability torecoverLiveDaemonsafter its own restart. It's important to note that the upstream PR for full restart-triggered hot upgrade functionality is currently not merged. Therefore, the scope of this particular test is focused on confirming that the snapshotter can successfully identify, reattach to, and manage existing runningnydusddaemons upon its own restart, thereby preventing container disruption. This test serves as a foundational verification for the eventual implementation of restart-triggered hot upgrades.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.