[WIP] nydusify: add layer push retry for copy subcommand #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
jiangliu,
gaius-qi and
hsiangkao
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 60.05% 60.05% -0.01%
==========================================
Files 147 147
Lines 49624 49624
Branches 47078 47078
==========================================
- Hits 29802 29800 -2
- Misses 18040 18041 +1
- Partials 1782 1783 +1 |
imeoer
changed the title
imeoer
force-pushed
the
nydusify-copy-layer-retry
branch
from
ab83655 to
5db44c3
Compare
imeoer
changed the title
Add push retry mechanism, enhance the success rate for image copy when a single layer copy failure. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer
force-pushed
the
nydusify-copy-layer-retry
branch
from
5db44c3 to
1f0f4a9
Compare
liubin
reviewed
Jan 24, 2025
To fix the retry mechanism of push in chunked. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Add push retry mechanism, enhance the success rate for image copy
when a single layer copy failure.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.