Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies to resolve cargo deny check failures #1660

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BraveY
Copy link

@BraveY BraveY commented Jan 15, 2025

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.
Bump rust version to stable version 1.84.0 and update dependencies to resolve the broken CI caused by cargo deny checks.

Since cross can't build openssl v1.68 on riscv64, use a custom Docker image to build on RISC-V64.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@BraveY BraveY requested a review from a team as a code owner January 15, 2025 08:13
@BraveY BraveY requested review from hsiangkao, power-more and Desiki-high and removed request for a team January 15, 2025 08:13
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 71.02804% with 31 lines in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (f60e40a) to head (d739f29).

Files with missing lines Patch % Lines
rafs/src/fs.rs 0.00% 8 Missing ⚠️
storage/src/meta/toc.rs 20.00% 2 Missing and 2 partials ⚠️
service/src/blob_cache.rs 25.00% 0 Missing and 3 partials ⚠️
src/bin/nydusd/main.rs 0.00% 3 Missing ⚠️
storage/src/cache/cachedfile.rs 0.00% 3 Missing ⚠️
service/src/daemon.rs 0.00% 2 Missing ⚠️
src/logger.rs 0.00% 2 Missing ⚠️
api/src/http_endpoint_v1.rs 0.00% 1 Missing ⚠️
api/src/http_handler.rs 94.11% 0 Missing and 1 partial ⚠️
rafs/src/metadata/layout/v5.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
+ Coverage   60.05%   60.41%   +0.35%     
==========================================
  Files         147      146       -1     
  Lines       49624    48926     -698     
  Branches    47078    46380     -698     
==========================================
- Hits        29802    29557     -245     
+ Misses      18040    17903     -137     
+ Partials     1782     1466     -316     
Files with missing lines Coverage Δ
builder/src/chunkdict_generator.rs 0.00% <ø> (ø)
builder/src/compact.rs 80.06% <100.00%> (+0.47%) ⬆️
builder/src/core/node.rs 81.82% <ø> (+0.54%) ⬆️
builder/src/core/v6.rs 77.18% <100.00%> (+1.70%) ⬆️
builder/src/stargz.rs 74.85% <ø> (+0.43%) ⬆️
builder/src/tarball.rs 62.69% <ø> (+0.04%) ⬆️
rafs/src/lib.rs 66.03% <ø> (+1.62%) ⬆️
rafs/src/metadata/cached_v5.rs 80.75% <100.00%> (+0.77%) ⬆️
rafs/src/metadata/direct_v5.rs 56.88% <100.00%> (+0.10%) ⬆️
rafs/src/metadata/layout/mod.rs 94.75% <100.00%> (+4.28%) ⬆️
... and 34 more

... and 75 files with indirect coverage changes

@BraveY BraveY marked this pull request as draft January 15, 2025 08:39
@BraveY BraveY closed this Jan 15, 2025
Yang Kaiyong added 2 commits January 17, 2025 11:35
…ny check failures

Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
@BraveY BraveY reopened this Jan 20, 2025
@BraveY BraveY marked this pull request as ready for review January 20, 2025 09:04
@BraveY BraveY requested a review from a team as a code owner January 20, 2025 09:04
@BraveY BraveY requested review from NehemiahMi and gaius-qi and removed request for a team January 20, 2025 09:04
rust-toolchain.toml Outdated Show resolved Hide resolved
.github/workflows/Rust-Cross-Compile-Dockerfile Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
.github/workflows/Dockerfile.cross Outdated Show resolved Hide resolved
Dockerfile.test Outdated Show resolved Hide resolved
Yang Kaiyong added 2 commits January 23, 2025 12:27
Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM.

rafs/Cargo.toml Outdated Show resolved Hide resolved
@BraveY BraveY force-pushed the fix-ci branch 3 times, most recently from 4da27f9 to d1849f5 Compare January 26, 2025 10:42
The backend-oss feature is nerver enabled, so comment the test code.

Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
@BraveY BraveY force-pushed the fix-ci branch 2 times, most recently from a88ab8d to d739f29 Compare January 26, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants