Skip to content

feat(manager+scheduler): add ExternalRedis TLS support (related to issue dragonflyoss/dragonly #4734)#502

Open
lavih wants to merge 5 commits into
dragonflyoss:mainfrom
lavih:feat/4734-external-redis-tls
Open

feat(manager+scheduler): add ExternalRedis TLS support (related to issue dragonflyoss/dragonly #4734)#502
lavih wants to merge 5 commits into
dragonflyoss:mainfrom
lavih:feat/4734-external-redis-tls

Conversation

@lavih
Copy link
Copy Markdown

@lavih lavih commented May 8, 2026

feat: add externalRedis TLS client configuration support

related to issue dragonflyoss/dragonfly#4734. Follow-up helm chart work for dragonflyoss/dragonfly#4738.

Exposes TLS client config for external Redis connections in both the manager and scheduler, mirroring the externalMysql TLS pattern already present in the chart.

Changes:

  • values.yaml / dragonfly-stack/values.yaml: add externalRedis.tls block (caCert, cert, key, insecureSkipVerify)
  • manager-configmap.yaml: wire externalRedis.tls into the manager's database.redis config
  • scheduler-configmap.yaml: wire externalRedis.tls into the scheduler's database.redis and job.redis configs
  • Chart.yaml: bump chart version to 1.6.27, appVersion to 2.4.4-rc.2

Supported shapes (matching the backend validator):

  • insecureSkipVerify: true — trust-on-first-use / managed Redis (ElastiCache, Azure Cache, Memorystore)
  • caCert only — server-side TLS
  • caCert + cert + key — mutual TLS

@github-actions github-actions Bot requested review from chlins, gaius-qi and yxxhero May 8, 2026 15:33
@gaius-qi gaius-qi added the enhancement New feature or request label May 11, 2026
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lavih Please modify the dragonfly chart, but do not change the dragonfly-stack chart.

@lavih lavih requested a review from gaius-qi May 11, 2026 17:39
@lavih lavih force-pushed the feat/4734-external-redis-tls branch 2 times, most recently from 584a954 to f125f65 Compare May 24, 2026 20:00
lavih and others added 5 commits May 24, 2026 23:06
…agonflyoss#4734)

Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Signed-off-by: lavih

Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Apply | quote filter to caCert, cert, and key string values in the
externalRedis TLS blocks to follow correct Helm idiom and guard
against YAML-special characters in file paths.

Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Lavih Berenstein <lavih44@gmail.com>
@lavih lavih force-pushed the feat/4734-external-redis-tls branch from f125f65 to a8aa806 Compare May 24, 2026 20:06
@lavih
Copy link
Copy Markdown
Author

lavih commented Jun 2, 2026

Hey @gaius-qi @chlins @yxxhero
Could you please review this code when you get a moment? I'd appreciate any feedback or suggestions you have.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants