Skip to content

fix(parent_selector): skip reconnect if connection exists, bump v1.3.2#1770

Merged
BraveY merged 1 commit intomainfrom
feature/log
Apr 7, 2026
Merged

fix(parent_selector): skip reconnect if connection exists, bump v1.3.2#1770
BraveY merged 1 commit intomainfrom
feature/log

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi commented Apr 7, 2026

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.5.0 milestone Apr 7, 2026
@gaius-qi gaius-qi self-assigned this Apr 7, 2026
@gaius-qi gaius-qi requested review from a team as code owners April 7, 2026 11:13
@gaius-qi gaius-qi requested a review from mingcheng April 7, 2026 11:13
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 7, 2026
@github-actions github-actions bot requested review from bergwolf, chlins and hyy0322 April 7, 2026 11:13
Copy link
Copy Markdown
Member

@EvanCley EvanCley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.53%. Comparing base (648b7a7) to head (2c3f3ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   44.50%   44.53%   +0.02%     
==========================================
  Files          91       91              
  Lines       25790    25790              
==========================================
+ Hits        11478    11485       +7     
+ Misses      14312    14305       -7     
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/mod.rs 0.00% <ø> (ø)
dragonfly-client/src/resource/parent_selector.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BraveY BraveY merged commit d056c5b into main Apr 7, 2026
9 checks passed
@BraveY BraveY deleted the feature/log branch April 7, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants