fix(object_storage): make credentials optional for ABS/OSS/OBS/COS#1753
Merged
fix(object_storage): make credentials optional for ABS/OSS/OBS/COS#1753
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 46.63% 46.42% -0.22%
==========================================
Files 87 87
Lines 24807 24692 -115
==========================================
- Hits 11569 11463 -106
+ Misses 13238 13229 -9
🚀 New features to boost your workflow:
|
hhhhsdxxxx
approved these changes
Mar 30, 2026
imeoer
approved these changes
Mar 30, 2026
jonakeys
pushed a commit
to jonakeys/dragonfly-client
that referenced
this pull request
Mar 30, 2026
…ragonflyoss#1753) Signed-off-by: Gaius <gaius.qi@gmail.com> Signed-off-by: Jonathan van der Steege <jonathan@jonakeys.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the credential handling logic for various object storage backends in
object_storage.rs. The main change is to require only theendpointfield as mandatory for Azure Blob Storage (ABS), Alibaba Cloud OSS, Huawei OBS, and Tencent COS backends, while making access key ID and secret optional. Credentials are now set conditionally if provided, and test cases are updated to reflect the new requirements.Credential Handling Refactor:
Changed the initialization of ABS, OSS, OBS, and COS operators to require only the
endpointfield as mandatory; access key ID and secret are now optional and set only if provided. This simplifies configuration and improves compatibility with different authentication methods. [1] [2] [3] [4] [5] [6] [7] [8]Updated builder logic for each backend to set credentials (
access_key_id,access_key_secret, etc.) only if they are present, instead of requiring them up front. [1] [2] [3] [4]Test Updates:
endpointis missing, rather than when access keys are missing, aligning with the new credential requirements. [1] [2] [3] [4] [5] [6] [7] [8]Documentation and Comments:
Minor Code Cleanups:
Bug Fixes:
Related Issue
Motivation and Context
Screenshots (if appropriate)