fix(sysinfo): use RSS instead of usage_in_bytes for cgroup memory stats#1739
Merged
fix(sysinfo): use RSS instead of usage_in_bytes for cgroup memory stats#1739
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
EvanCley
approved these changes
Mar 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
+ Coverage 46.79% 46.82% +0.03%
==========================================
Files 87 87
Lines 24883 24881 -2
==========================================
+ Hits 11643 11650 +7
+ Misses 13240 13231 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and refactors to the system resource monitoring components, primarily focusing on enhanced accuracy, async handling, and richer diagnostics. The most notable changes are the switch to async CPU stat collection, improved cgroup support for container environments, and the addition of detailed debug logging throughout the sysinfo modules.
Resource Monitoring Enhancements
get_statsandget_process_statsinCPU) asynchronous, allowing for more accurate and up-to-date readings by refreshing and waiting between samples. [1] [2]Container Environment Support
SchedulerAnnouncer. [1] [2] [3] [4]Debug Logging Improvements
Version Updates
1.2.17to1.2.18inCargo.toml, and updated all workspace dependency versions accordingly. [1] [2]Code Structure and Accuracy Improvements
These changes collectively increase the reliability and transparency of system resource monitoring, especially in containerized environments, and facilitate easier debugging and maintenance.
Related Issue
Motivation and Context
Screenshots (if appropriate)