fix(grpc): downgrade connection broken log from error to debug level#1736
Merged
fix(grpc): downgrade connection broken log from error to debug level#1736
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
hhhhsdxxxx
approved these changes
Mar 19, 2026
CormickKneey
approved these changes
Mar 19, 2026
imeoer
approved these changes
Mar 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise in the gRPC upload server by downgrading a “connection broken” log from error! to debug!, reflecting that a closed stream/channel during host sync is typically a normal condition rather than an actionable error.
Changes:
- Downgrade the “connection broken” log in
DfdaemonUploadServerHandler::sync_hostfromerror!todebug! - Refine the log message wording for clarity
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 87 87
Lines 24816 24816
=======================================
Hits 11629 11629
Misses 13187 13187
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes a minor adjustment to the logging level in the
DfdaemonUploadServerHandlerimplementation. The change downgrades the log message fromerror!todebug!and updates the wording for clarity. This helps reduce noise in error logs when a connection is broken, making it easier to focus on more critical issues.error!todebug!and updated the message in the connection handling code ofdragonfly-client/src/grpc/dfdaemon_upload.rs.Related Issue
Motivation and Context
Screenshots (if appropriate)