Skip to content

fix(grpc): downgrade connection broken log from error to debug level#1736

Merged
gaius-qi merged 1 commit intomainfrom
feature/log
Mar 19, 2026
Merged

fix(grpc): downgrade connection broken log from error to debug level#1736
gaius-qi merged 1 commit intomainfrom
feature/log

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

This pull request makes a minor adjustment to the logging level in the DfdaemonUploadServerHandler implementation. The change downgrades the log message from error! to debug! and updates the wording for clarity. This helps reduce noise in error logs when a connection is broken, making it easier to focus on more critical issues.

  • Changed log level from error! to debug! and updated the message in the connection handling code of dragonfly-client/src/grpc/dfdaemon_upload.rs.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.5.0 milestone Mar 19, 2026
@gaius-qi gaius-qi self-assigned this Mar 19, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 19, 2026
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi enabled auto-merge (squash) March 19, 2026 08:21
@mingcheng mingcheng requested review from Copilot and mingcheng March 19, 2026 08:21
Copy link
Copy Markdown
Member

@mingcheng mingcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise in the gRPC upload server by downgrading a “connection broken” log from error! to debug!, reflecting that a closed stream/channel during host sync is typically a normal condition rather than an actionable error.

Changes:

  • Downgrade the “connection broken” log in DfdaemonUploadServerHandler::sync_host from error! to debug!
  • Refine the log message wording for clarity

@gaius-qi gaius-qi merged commit c1e757c into main Mar 19, 2026
13 checks passed
@gaius-qi gaius-qi deleted the feature/log branch March 19, 2026 08:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.86%. Comparing base (7d33221) to head (d52e473).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          87       87           
  Lines       24816    24816           
=======================================
  Hits        11629    11629           
  Misses      13187    13187           
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants