fix: move BBR duration fields to workspace dep and fix serde#1735
Merged
fix: move BBR duration fields to workspace dep and fix serde#1735
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
- Coverage 46.86% 46.86% -0.01%
==========================================
Files 87 87
Lines 24815 24816 +1
==========================================
Hits 11629 11629
- Misses 13186 13187 +1
🚀 New features to boost your workflow:
|
CormickKneey
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request primarily updates dependency versions and improves configuration handling for time durations. The most notable changes are version bumps across the workspace, improved serialization of duration fields using
humantime-serde, and minor code fixes for error messages and middleware cloning.Dependency version updates:
1.2.16to1.2.17inCargo.toml, ensuring consistency across the project. [1] [2]humantime-serdeto be a workspace dependency indragonfly-client-config/Cargo.tomlanddragonfly-client-util/Cargo.toml, removing direct version specification. [1] [2]humantime-serde = "1.1.1"to the workspace dependencies inCargo.toml.Configuration improvements:
BBRConfigby usinghumantime-serde, making configuration files more human-readable and easier to maintain. [1] [2]Code fixes:
dfdaemon_download.rsanddfdaemon_upload.rs. [1] [2]dragonfly-client/src/grpc/middleware.rsby usingstd::mem::replace, ensuring correct ownership and avoiding potential issues.Related Issue
Motivation and Context
Screenshots (if appropriate)