Skip to content

fix: move BBR duration fields to workspace dep and fix serde#1735

Merged
gaius-qi merged 2 commits intomainfrom
feature/bbr
Mar 18, 2026
Merged

fix: move BBR duration fields to workspace dep and fix serde#1735
gaius-qi merged 2 commits intomainfrom
feature/bbr

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

This pull request primarily updates dependency versions and improves configuration handling for time durations. The most notable changes are version bumps across the workspace, improved serialization of duration fields using humantime-serde, and minor code fixes for error messages and middleware cloning.

Dependency version updates:

  • Bumped the workspace version and all internal dependencies from 1.2.16 to 1.2.17 in Cargo.toml, ensuring consistency across the project. [1] [2]
  • Updated humantime-serde to be a workspace dependency in dragonfly-client-config/Cargo.toml and dragonfly-client-util/Cargo.toml, removing direct version specification. [1] [2]
  • Added humantime-serde = "1.1.1" to the workspace dependencies in Cargo.toml.

Configuration improvements:

  • Enhanced serialization of duration fields in BBRConfig by using humantime-serde, making configuration files more human-readable and easier to maintain. [1] [2]

Code fixes:

  • Changed the error message in gRPC server overload responses to use lowercase for consistency in dfdaemon_download.rs and dfdaemon_upload.rs. [1] [2]
  • Improved middleware cloning logic in dragonfly-client/src/grpc/middleware.rs by using std::mem::replace, ensuring correct ownership and avoiding potential issues.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.5.0 milestone Mar 18, 2026
@gaius-qi gaius-qi self-assigned this Mar 18, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 18, 2026
@gaius-qi gaius-qi enabled auto-merge (squash) March 18, 2026 07:57
@gaius-qi gaius-qi changed the title Feature/bbr fix: move BBR duration fields to workspace dep and fix serde Mar 18, 2026
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.86%. Comparing base (01d0d11) to head (d1c345a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/grpc/middleware.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   46.86%   46.86%   -0.01%     
==========================================
  Files          87       87              
  Lines       24815    24816       +1     
==========================================
  Hits        11629    11629              
- Misses      13186    13187       +1     
Files with missing lines Coverage Δ
dragonfly-client-util/src/ratelimiter/bbr.rs 79.62% <ø> (-0.19%) ⬇️
dragonfly-client/src/grpc/dfdaemon_download.rs 5.03% <0.00%> (ø)
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/grpc/middleware.rs 25.80% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit 7d33221 into main Mar 18, 2026
9 checks passed
@gaius-qi gaius-qi deleted the feature/bbr branch March 18, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants