Skip to content

chore: add version field to mocktail git dependency in Cargo.toml#1733

Merged
gaius-qi merged 1 commit intomainfrom
feature/mocktail
Mar 17, 2026
Merged

chore: add version field to mocktail git dependency in Cargo.toml#1733
gaius-qi merged 1 commit intomainfrom
feature/mocktail

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

Description

This pull request updates the mocktail dependency configuration in Cargo.toml to include both a version and a git reference, along with a clarifying TODO comment. This ensures compatibility with the current codebase while documenting the intent to remove the git dependency in the future.

Dependency management:

  • Updated the mocktail dependency to specify both a version (0.3.0) and a git reference, and added a TODO comment referencing the upstream issue for future cleanup.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.5.0 milestone Mar 17, 2026
@gaius-qi gaius-qi self-assigned this Mar 17, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 17, 2026
@gaius-qi gaius-qi enabled auto-merge (squash) March 17, 2026 14:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.89%. Comparing base (9d9b5ec) to head (5122888).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1733   +/-   ##
=======================================
  Coverage   46.89%   46.89%           
=======================================
  Files          87       87           
  Lines       24811    24811           
=======================================
  Hits        11636    11636           
  Misses      13175    13175           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit e9ff969 into main Mar 17, 2026
9 checks passed
@gaius-qi gaius-qi deleted the feature/mocktail branch March 17, 2026 14:33
@mingcheng
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants