Skip to content

Proxy rule routes non-GET requests to download_task #1772

@Looka149

Description

@Looka149

Bug report:

find_matching_rule() does not check HTTP method. When a HEAD/PUT/POST/DELETE request matches a proxy rule, it is routed to download_task which only handles read operations. This causes write failure or silent data loss.

Expected behavior:

Only GET requests should be routed to download_task. Other methods should be proxied directly to the origin server.

How to reproduce it:

  1. Set a proxy rule that matches the target URL and HTTPS_PROXY to dfdaemon
  2. Send a PUT request to a URL that matches the rule
  3. Observe: PUT is routed to proxy_via_dfdaemondownload_task → write fails

Environment:

  • Client version:
  • OS:
  • Kernel (e.g. uname -a):
  • Others:

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions