Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set self-signed cert for service #3568

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Oct 11, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 11, 2024
@gaius-qi gaius-qi self-assigned this Oct 11, 2024
@gaius-qi gaius-qi requested review from a team as code owners October 11, 2024 12:50
@gaius-qi gaius-qi force-pushed the feature/self-signed-cert branch 2 times, most recently from c8c1e37 to a4dc6cf Compare October 11, 2024 13:08
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.39%. Comparing base (da10972) to head (a298d65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/config/dynconfig.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
+ Coverage   49.73%   53.39%   +3.66%     
==========================================
  Files         186      176      -10     
  Lines       19527    18059    -1468     
==========================================
- Hits         9712     9643      -69     
+ Misses       9020     7633    -1387     
+ Partials      795      783      -12     
Flag Coverage Δ
unittests 53.39% <97.82%> (+3.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/peerhost.go 45.51% <ø> (-1.48%) ⬇️
client/config/peerhost_linux.go 100.00% <ø> (ø)
manager/config/config.go 96.05% <100.00%> (-0.28%) ⬇️
scheduler/config/config.go 88.54% <100.00%> (ø)
scheduler/resource/standard/resource.go 63.63% <100.00%> (-0.65%) ⬇️
scheduler/config/dynconfig.go 21.39% <85.71%> (-0.95%) ⬇️

... and 8 files with indirect coverage changes

@gaius-qi gaius-qi changed the title feat: support set self-signed cert for service @gaius-qi feat: support set self-signed cert for service Oct 11, 2024
@gaius-qi gaius-qi force-pushed the feature/self-signed-cert branch 2 times, most recently from eca1362 to 59bdee4 Compare October 11, 2024 14:21
…e/self-signed-cert

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit e3b8583 into main Oct 11, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/self-signed-cert branch October 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants