feat: add snapshot-id field into dfs files #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please change the PR description and add the commit description of the change. |
romange
reviewed
Jul 2, 2025
|
@BorysTheDev I added my commit and all the rdb_tests pass. Please let me know if you think it's wrong. |
romange
reviewed
Jul 2, 2025
|
please rebase |
BorysTheDev
force-pushed
the
add_snapshot_id_field_into_dfs_files
branch
from
5da151e to
f84ea0c
Compare
romange
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5284
Problem: Currently, different dfs snapshot files can be loaded as part of the same logical snapshot if they have the same name pattern.
Fix: Added SnapshotId AUX field into dfs files to distinguish files that can belong to another snapshot