Skip to content

fix: test_migration_timeout_on_sync #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BorysTheDev merged 1 commit into from
Apr 14, 2025
Merged

fix: test_migration_timeout_on_sync #4933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/server/debugcmd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,8 @@ void DebugCmd::Run(CmdArgList args, facade::SinkReplyBuilder* builder) {
" existing RDB file.",
"REPLICA PAUSE/RESUME",
" Stops replica from reconnecting to master, or resumes",
"MIGRATION PAUSE/RESUME",
" Stops/resumes incoming migration process only in the SYNC state",
"REPLICA OFFSET",
" Return sync id and array of number of journal commands executed for each replica flow",
"WATCHED",
Expand Down
3 changes: 2 additions & 1 deletion tests/dragonfly/cluster_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2745,7 +2745,8 @@ async def test_migration_timeout_on_sync(df_factory: DflyInstanceFactory, df_see
await push_config(json.dumps(generate_config(nodes)), [node.admin_client for node in nodes])

await asyncio.sleep(random.randint(0, 50) / 100)
await wait_for_migration_start(nodes[1].admin_client, nodes[0].id)
# to pause migration we need to be in sync state
await wait_for_status(nodes[1].admin_client, nodes[0].id, "SYNC", 1000)

logging.debug("debug migration pause")
await nodes[1].client.execute_command("debug migration pause")
Expand Down
Loading