Skip to content

fix: add version id for dev container builds #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romange merged 1 commit into from
Apr 2, 2025
Merged

fix: add version id for dev container builds #4878

romange merged 1 commit into from
Apr 2, 2025

Conversation

@romange
Copy link
Collaborator

@romange romange commented Apr 2, 2025

now it looks like this:

> docker run --rm ghcr.io/dragonflydb/dragonfly-dev:ubuntu-f767d82 --version
dragonfly f767d82-f767d82ce78ccbc90ddfb525f4ad4bd9aafcfbed

fixes #4830

@romange
fix: add version id for dev container builds
01a39df 
now it looks like this:
```
> docker run --rm ghcr.io/dragonflydb/dragonfly-dev:ubuntu-f767d82 --version
dragonfly f767d82-f767d82ce78ccbc90ddfb525f4ad4bd9aafcfbed
```

fixes #4830

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange requested a review from BorysTheDev April 2, 2025 14:50
@romange romange merged commit 4606908 into main Apr 2, 2025
10 checks passed
@romange romange deleted the Pr2 branch April 2, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BorysTheDev BorysTheDev BorysTheDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

our dev releases do not show version

3 participants

@romange @BorysTheDev