Skip to content

Commit

Permalink
Merge pull request grpc#20810 from hcaseyal/contributing
Browse files Browse the repository at this point in the history
Update contributing doc with copyright message info
  • Loading branch information
hcaseyal authored Oct 25, 2019
2 parents 75e2540 + 1784f2e commit 8f7201e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ How to get your contributions merged smoothly and quickly.
- Don't fix code style and formatting unless you are already changing that line
to address an issue. PRs with irrelevant changes won't be merged. If you do
want to fix formatting or style, do that in a separate PR.

- If you are adding a new file, make sure it has the copyright message template
at the top as a comment. You can copy over the message from an existing file
and update the year.

- Unless your PR is trivial, you should expect there will be reviewer comments
that you'll need to address before merging. We expect you to be reasonably
Expand Down

0 comments on commit 8f7201e

Please sign in to comment.