Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| } | ||
| }, [isFullscreen, videoMediaObject]); | ||
|
|
||
| const updateAudioMode = React.useCallback(async () => { |
There was a problem hiding this comment.
Consider using useEffect to update the audio mode when playsInSilentModeIOS changes rather than only on toggle playback. This ensures the audio mode is set on mount and when the prop updates.
|
Published version: @draftbit/ui@50.8.5-7350f5.2 |
|
Published version: @draftbit/ui@50.8.5-ac601e.2 |
|
Published version: @draftbit/ui@50.8.5-08c65b.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
playsInSilentModeIOSprop toVideoPlayerto support silent mode on iOS, with implementation inVideoPlayer.tsx.playsInSilentModeIOSprop toVideoPlayerinVideoPlayer.tsxto support silent mode on iOS.playsInSilentModeIOSisfalse.Audio.setAudioModeAsyncinupdateAudioModeto setplaysInSilentModeIOS.updateAudioModeinuseEffectandonTogglePlaybackinVideoPlayer.tsx.VideoPlayerExample.tsxto new URIs.This description was created by
for 0e11044. It will automatically update as commits are pushed.