Skip to content

Support prop ignore reduce motion for bottom sheet #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sieu-db merged 3 commits into from
Dec 27, 2024
Merged

Support prop ignore reduce motion for bottom sheet #979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da19ceb
support prop ignore reduce motion for bottom sheet
sieu-db Dec 27, 2024
5c1816c
support ignore reduce motion for bottom sheet
sieu-db Dec 27, 2024
a615865
support ignore reduce motion for bottom sheet
sieu-db Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/components/BottomSheet/BottomSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import BottomSheetComponent, {
} from "@gorhom/bottom-sheet";
import { useTheme } from "@draftbit/theme";
import { extractPercentNumber, useDeepCompareMemo } from "../../utilities";
import { ReduceMotion } from "react-native-reanimated";

type SnapPosition = "top" | "middle" | "bottom";

Expand All @@ -38,6 +39,7 @@ export interface BottomSheetProps extends ScrollViewProps {
enableDynamicSizing?: boolean;
onSettle?: (index: number) => void;
style?: StyleProp<ViewStyle>;
ignoreReduceMotion?: boolean;
}

// Clarification:
Expand All @@ -61,6 +63,7 @@ const BottomSheet = React.forwardRef<BottomSheetComponent, BottomSheetProps>(
onSettle,
style,
children,
ignoreReduceMotion = true,
...rest
},
ref
Expand Down Expand Up @@ -119,6 +122,9 @@ const BottomSheet = React.forwardRef<BottomSheetComponent, BottomSheetProps>(
? onSettle?.(mappedSnapPoints.length - index)
: onSettle?.(mappedSnapPoints.length - index - 1)
}
overrideReduceMotion={
ignoreReduceMotion ? ReduceMotion.Never : ReduceMotion.System
}
>
<BottomSheetScrollView
contentContainerStyle={[styles.contentContainerStyle, style]}
Expand Down
Loading