Skip to content

Conversation

graham83
Copy link
Contributor

Minor fix to resolve issue https://draftable.atlassian.net/browse/CL-129
Also added some comments to documentation to remind clients to check comparison for ready status

@graham83 graham83 requested a review from ralish November 17, 2022 18:31
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 75.00% // Head: 75.17% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (544a7d1) compared to base (6238b85).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   75.00%   75.17%   +0.17%     
==========================================
  Files          19       19              
  Lines         576      576              
  Branches       69       53      -16     
==========================================
+ Hits          432      433       +1     
+ Misses        117      116       -1     
  Partials       27       27              
Impacted Files Coverage Δ
draftable/endpoints/comparisons/comparisons.py 96.15% <100.00%> (ø)
draftable/endpoints/comparisons/comparison.py 65.93% <0.00%> (+1.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graham83 graham83 merged commit 26ca50f into main Nov 17, 2022
@graham83
Copy link
Contributor Author

graham83 commented Nov 17, 2022

@ralish - It was a one liner so went ahead and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant