Open
Conversation
aapomm
commented
Feb 9, 2026
| end | ||
| end | ||
|
|
||
| context 'uploading file with special characters in the filename' do |
Collaborator
Author
There was a problem hiding this comment.
Removed case as it doesn't actually work
gcelanji
reviewed
Feb 9, 2026
|
|
||
| def state | ||
| @state ||= | ||
| Issue.states.keys.include?(params[:state]) ? params[:state] : 'draft' |
Contributor
There was a problem hiding this comment.
Suggested change
| Issue.states.keys.include?(params[:state]) ? params[:state] : 'draft' | |
| Issue.states.key?(params[:state]) ? params[:state] : 'draft' |
gcelanji
reviewed
Feb 9, 2026
| end | ||
| end | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
Can we add a test case for handling invalid states (which defaults to draft in the controller)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
When uploading a CSV file, a user is able to choose the state. However, currently, this state isn't used in the backend at all.
Proposed solution
Check List