Update README.md #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmil
reviewed
Sep 1, 2024
There was a problem hiding this comment.
@lucagiovannini7 Technically, the README looks fine. However, does it make sense to maintain this list of sources manually when all the data is already available in the TEI files. The list is actually very similar to https://staging.dracor.org/am, except that we don't link the exact online resource nor list the author's gender.
@lehkost Should we just link the sources in the corpus table in the frontend? Then we could simply refer to the respective dracor.org page instead of doing this double work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised readme with all info about play sources
(it was supposed to be committed before DH24, but we somehow lost sight of it)