Skip to content

Fixed empty spans dropped at the end of enumeration #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2024
Merged

Fixed empty spans dropped at the end of enumeration #10

merged 2 commits into from
Jan 27, 2024

Conversation

Guiorgy
Copy link
Contributor

@Guiorgy Guiorgy commented Jan 27, 2024 •
edited
Loading

If the last span in an enumeration was empty, it would be erroneously dropped.

@Guiorgy
Copy link
Contributor Author

Guiorgy commented Jan 27, 2024 •
edited
Loading

Wait, I accidentally targeted main. Can you change the base branch to dev, or should I recreate the PR? Nevermind, changed.

@Guiorgy Guiorgy changed the base branch from main to dev January 27, 2024 15:20
@dragon7307
Copy link
Member

Great, I'll look through it and be resolving the merge conflicts.

@dragon7307
Copy link
Member

Looks fine to me - merging it now!!

@dragon7307 dragon7307 merged commit ea1e61d into draconware-dev:dev Jan 27, 2024
@Guiorgy Guiorgy deleted the fix-empty-span-skipped-at-the-end branch January 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guiorgy @dragon7307