Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus-cpp to v1.2.4 #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update prometheus-cpp to v1.2.4 #288

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jun 21, 2023

No description provided.

@xquanluu
Copy link
Collaborator

Hi @orgads

It seem that we are wroking on same issue, could you please help me to review the PR from me: #287

I hope you can give me some comment to make it the best.

I'm still trying to fix CI failure there. It's great if you also can help me on that PR.

@orgads orgads changed the title Fix compilation with recent prometheus-cpp Update prometheus-cpp Jun 21, 2023
@orgads orgads force-pushed the prometheus branch 2 times, most recently from 87f83b2 to 7eb88db Compare June 21, 2023 11:14
@orgads
Copy link
Contributor Author

orgads commented Jun 21, 2023

Which prometheus version did you checkout? I used tag v1.1.0. Build passes here (even without upgrading ubuntu): https://github.com/orgads/drachtio-server/actions/runs/5331207087

@orgads orgads force-pushed the prometheus branch 2 times, most recently from 8e55669 to db55a8b Compare June 24, 2023 19:27
@orgads orgads changed the title Update prometheus-cpp Update prometheus-cpp to v1.1.0 Jun 24, 2023
@orgads
Copy link
Contributor Author

orgads commented Jun 29, 2023

ping

@orgads
Copy link
Contributor Author

orgads commented Aug 21, 2023

@davehorton ping

@orgads orgads changed the title Update prometheus-cpp to v1.1.0 Update prometheus-cpp to v1.2.4 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @xquanluu