Skip to content

Commit

Permalink
fix: don't ship an Ivy compiled library
Browse files Browse the repository at this point in the history
Shipping as Ivy compiled is not recommended by Angular it it breaks
every library that has a dependency on ngx-bootstrap and that does
not ship as Ivy  compiled.

Enabling "fullTemplateTypeCheck" also works around an Angular compiler
problem regarding the `forRoot()` not working..

See valor-software#5862
  • Loading branch information
dr-itz committed Aug 26, 2020
1 parent 0b6fd99 commit fdc2681
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scripts/ng-packagr/tsconfig.ngc.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
{
"angularCompilerOptions": {
"enableIvy": false,
"disableExpressionLowering": true,
"annotateForClosureCompiler": true,
"skipTemplateCodegen": true,
"strictMetadataEmit": true,
"fullTemplateTypeCheck": false,
"fullTemplateTypeCheck": true,
"enableResourceInlining": true
},
"buildOnSave": false,
Expand Down

0 comments on commit fdc2681

Please sign in to comment.