Skip to content

Conversation

@fggarcia
Copy link
Contributor

@fggarcia fggarcia commented Nov 26, 2025

This pull request removes experimental converters for "hotcold" and "pprof" formats, simplifies output types, and updates dependencies. The main impact is the removal of support for "hotcold" and "nflx" output types, as well as the associated converter implementations. Additionally, there are minor improvements to string padding logic and a dependency update.

Removal of experimental converters and output types:

  • Deleted the jfr2hotcoldflame and jfr2pprof experimental converter implementations, removing support for hot/cold flame graphs and pprof conversion (src/main/java/io/github/dpsoft/ap/converters/experimental/hotcold/jfr2hotcoldflame.java, src/main/java/io/github/dpsoft/ap/converters/experimental/pprof/jfr2pprof.java) [1] [2].
  • Removed the experimental package-info and related import statements, fully cleaning up unused experimental code (src/main/java/io/github/dpsoft/ap/converters/experimental/package-info.java, src/main/java/io/github/dpsoft/ap/util/ProfilerExecutor.java) [1] [2].

Simplification of output types and logic:

  • Removed HOT_COLD and NFLX output types from the Output enum and related logic in Command.java, so these formats are no longer available as output options (src/main/java/io/github/dpsoft/ap/command/Command.java) [1] [2].

Dependency and code improvements:

  • Updated the me.bechberger.ap-loader.version property in pom.xml to a newer version, ensuring compatibility with recent changes.
  • Simplified the string padding logic in Functions.java to use modern Java features for cleaner code (src/main/java/io/github/dpsoft/ap/functions/Functions.java).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the async-profiler dependency from version 2.9-6 to 4.2-10 and removes experimental converter implementations. The changes simplify the codebase by removing support for hot/cold flame graphs and Netflix FlameScope output formats, while updating the integration with the newer async-profiler API.

  • Updated async-profiler loader dependency from version 2.9-6 to 4.2-10
  • Removed experimental converter classes and the HOT_COLD and NFLX output types
  • Refactored output conversion logic to use new converter classes from the updated dependency
  • Fixed a bug in string padding logic

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pom.xml Updates ap-loader dependency version to 4.2-10 to support async-profiler 4.2
src/main/java/io/github/dpsoft/ap/command/Command.java Removes HOT_COLD and NFLX output enum values and updates shouldCompress() logic
src/main/java/io/github/dpsoft/ap/util/ProfilerExecutor.java Migrates from one.converter.* to one.convert.* package, refactors conversion methods to use new converter classes, and extracts getArguments() helper method
src/main/java/io/github/dpsoft/ap/functions/Functions.java Simplifies padString() implementation using String.repeat() and fixes off-by-one padding bug
src/main/java/io/github/dpsoft/ap/converters/experimental/pprof/jfr2pprof.java Deletes experimental pprof converter (now provided by dependency)
src/main/java/io/github/dpsoft/ap/converters/experimental/hotcold/jfr2hotcoldflame.java Deletes experimental hot/cold converter implementation
src/main/java/io/github/dpsoft/ap/converters/experimental/hotcold/HotColdFlameGraph.java Deletes experimental hot/cold flame graph visualization class
src/main/java/io/github/dpsoft/ap/converters/experimental/package-info.java Removes package documentation for deleted experimental package
src/main/java/one/converter/CollapsedStacks.java Deletes CollapsedStacks class (now provided by updated dependency)
src/main/java/one/converter/Arguments.java Deletes Arguments class (now provided by updated dependency in one.convert package)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@dpsoft dpsoft merged commit 30440fc into dpsoft:main Nov 26, 2025
6 checks passed
@dpsoft
Copy link
Owner

dpsoft commented Nov 26, 2025

@fggarcia awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants