Failure in test suite

[fabaff]

In 0.9.0 is a failure which now prevents the RPM package for Fedora to be build.

$ python3 setup.py test
running test
running egg_info
writing json5.egg-info/PKG-INFO
writing dependency_links to json5.egg-info/dependency_links.txt
writing entry points to json5.egg-info/entry_points.txt
writing top-level names to json5.egg-info/top_level.txt
reading manifest file 'json5.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'json5.egg-info/SOURCES.txt'
running build_ext
test_basic (tests.lib_test.TestDump) ... ok
[...]
test_unknown_switch (tests.tool_test.ToolTest) ... ok
test_version (tests.tool_test.ToolTest) ... ok

======================================================================
FAIL: test_skip_keys (tests.lib_test.TestDumps)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/fab/Documents/repos/pyjson5/tests/lib_test.py", line 379, in test_skip_keys
    '{foo: 1}')
AssertionError: '{foo: 1, }' != '{foo: 1}'
- {foo: 1, }
?        --
+ {foo: 1}


----------------------------------------------------------------------
Ran 61 tests in 0.121s

FAILED (failures=1)
Test failed: <unittest.runner.TextTestResult run=61 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=61 errors=0 failures=1>

Would be nice if you could fix it and release 0.9.1. Thanks.

[dpranke]

Thanks for the bug report! I've verified that I see it, too. I'll get on this ASAP, and see if I can also get a better test infra in place using tox et al (which I've been meaning to do for quite some time) to keep this from happening again.

[dpranke]

This is now fixed in 2ed8a4a; I've tagged and released v0.9.1 on PyPI as well.

I've not yet added better tox support or anything else like that to do better release checking, though.

[fabaff]

Thanks for the quick reaction.

[fabaff]

Update done -> https://src.fedoraproject.org/rpms/python-json5