Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background image shorthand #25

Merged
merged 3 commits into from
Feb 19, 2019

Conversation

mrmanc
Copy link
Collaborator

@mrmanc mrmanc commented Feb 5, 2019

This introduced <backgroundimage> notation and is covered in the README.

@dploeger
Copy link
Owner

dploeger commented Feb 5, 2019

Would be a minor version, right? No breaking changes. Just a new feature?

@mrmanc
Copy link
Collaborator Author

mrmanc commented Feb 5, 2019

Absolutely. I have another incoming but intrigued to see if you like it.

@dploeger
Copy link
Owner

dploeger commented Feb 5, 2019

Actually, @mrmanc would you like be an official contributor for this repo? You're mainly developing this thing now. 😄

Copy link
Contributor

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For implementing this.

README.md Show resolved Hide resolved
@mrmanc
Copy link
Collaborator Author

mrmanc commented Feb 12, 2019

Actually, @mrmanc would you like be an official contributor for this repo? You're mainly developing this thing now. 😄

Apologies, I never thanked you for that! Thanks! :)

@mrmanc mrmanc merged commit 95d4ef8 into dploeger:master Feb 19, 2019
@mrmanc mrmanc deleted the add-image-background-shorthand branch September 5, 2022 13:33
@mrmanc mrmanc changed the title Add image background shorthand Add background image shorthand Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants