Replace plugins with includes for GHP compatibility #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom Jekyll plugins did not work with GitHub Pages so this change provides Jekyll includes which are compatible, although slightly more verbose in their use.
Closed
To accommodate a less verbose approach to marking items as fragments and changing the background, the documentation mentions both approaches with a note about the fact that using GitHub Pages requires the user to use the include mechanism.
|
Looks good. Could you please revert the sample slides to use the liquid tags, because we agreed on primarily supporting the liquid tags and only use the inclusion feature for GHP support. |
I’ve moved the code from index.html into the layout since it now contains some logic (the Liquid filter) which expands the syntax into something that reveal.js understands. Existing plugins are still supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom Jekyll plugins did not work with GitHub Pages so this change provides Jekyll includes which are compatible, although slightly more verbose in their use.
Fixes #7.