Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description and author are not configurable #18

Closed
mrmanc opened this issue Jan 9, 2019 · 4 comments
Closed

Description and author are not configurable #18

mrmanc opened this issue Jan 9, 2019 · 4 comments

Comments

@mrmanc
Copy link
Collaborator

mrmanc commented Jan 9, 2019

I just noticed that the description and author are hard-coded in the layout. I’m guessing you’d be open to a change which made this configurable? Otherwise services like Slack will present the reveal.js tagline rather than something related to the presentation in the snippet alongside a link.

@dploeger
Copy link
Owner

Yes, very open. This was just not in the focus. Thanks! 🎁

@infotexture
Copy link
Contributor

This would be a welcome change indeed. 👍

Regarding the layout file, I noticed there's quite a mix of spaces & tabs in _layouts/reveal.html and considered normalizing that, but not sure how closely this tracks an upstream reveal.js template and didn't want to complicate future diffing. 🤔

@mrmanc
Copy link
Collaborator Author

mrmanc commented Feb 5, 2019

I’m on too as we speak 😂About to push and PR, but don’t want to step on your feet. Good spot on the whitespace… I’ve just replaced all the spaces with tabs as per what looks like the original file.

@infotexture
Copy link
Contributor

👍 Go for it. Hadn't touched it to prevent conflicts.

dploeger added a commit that referenced this issue Feb 5, 2019
…urable

Fixes #18 by reading description and author from the site configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants