Make the "mock" dependency optional (only used in Python 2.7).

[Romain-Geissler-1A]

"mock" is included inside the standard "unittest" package in Python >= 3.3.

(This is an alternatve version of what was proposed (and declined) earlier in #2516. The idea is to allow distributions to package kafka-python without having to patch it explicitly to remove the "mock" dependency).

[dpkp]

I think I can merge this, thanks for the update. Can you show me what commands you are using to package that break on the current master? Our intent was to make testing dependencies / requirements-dev optional and wouldn't expect them to be included generally. The are not included in wheels uploaded to pypi, for example.

[Romain-Geissler-1A]

Actually we have upgraded python-kafka in Fedora + EPEL 10 this week-end, including the diff of the closed pull request #2516: https://src.fedoraproject.org/rpms/python-kafka/pull-request/4#request_diff They way most fedora python packages are built are via some %pyproject_ macros, which honestly I don't really know what they do. See the spec file here: https://src.fedoraproject.org/rpms/python-kafka/blob/rawhide/f/python-kafka.spec The most basic use case is to read the pyproject.toml and look for dependencies there, but I have seen other package defining their dependencies either a tox.ini file or various requirements.txt files. These macro will try to discover dependencies this way, and "convert" these to actual RPM packages dependencies. In Fedora, python-mock has been removed already, no one is meant to depend on it anymore, and thus right now trying to package python-kafka without any patch results in a missing mock dependency. Note that usually fedora packages try to run tests (which often catches some breakages when something changes).

[dpkp]

can we make this < '3.3' ?

[dpkp]

same -- prefer to cover all python before unittest.mock added in 3.3

[Romain-Geissler-1A]

I have update the version constraint to < '3.3' everywhere as suggested.

[dpkp]

sorry, i also removed tox.ini and you'll need to rebase against that change before I can merge :(

[dpkp]

Thanks!