Call ApiVersionsRequest during connection, prior to Sasl Handshake#2493
Merged
Call ApiVersionsRequest during connection, prior to Sasl Handshake#2493
Conversation
dpkp
force-pushed
the
dpkp/check-versions-conn-state
branch
6 times, most recently
from
e45d523 to
ce679b6
Compare
|
Nice to see all the protocol support improvements. Are we also planning to support KIP-511? That's very helpful for users to understand which clients and versions are being used within their applications. |
Owner
Author
Yes, but as I understand it that change requires flexible version support / tags and so I'll likely tackle after getting to 2.1 baseline. |
dpkp
force-pushed
the
dpkp/check-versions-conn-state
branch
3 times, most recently
from
b527441 to
c6d3b4e
Compare
dpkp
force-pushed
the
dpkp/check-versions-conn-state
branch
from
c6d3b4e to
4149e0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves ApiVersionsRequest into pre-connection state handling, prior to SaslHandshake. Use v2 for initial request and check for UnsupportedVersionError.
Skips ApiVersionsRequest if
api_versionhas been configured by user.