Add log_start_offset to message protocol parsing
#2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2020 16:25
…all but the zstd related stuff)
jeffwidman
changed the title
log_start_offset to message protocol parsing
|
I'd like @dpkp and @tvoinarovskyi to take a look as well, particularly at the error handling bit. |
|
@gabriel-tincu Great job on this, really appreciate your contribution. |
added 2 commits
March 19, 2020 20:09
gabriel-tincu
force-pushed
the
gabi-kafka-client-zstd-produce-update
branch
from
32840cb
to
aaf61ff
Compare
|
Nice! LGTM |
tvoinarovskyi
approved these changes
Mar 20, 2020
|
@jeffwidman Code looks good, but the current CI does not actually run 2.1 tests as API version checks are not up to date with the latest brokers. I will do a fix in separate PR, don't think it's a blocker. |
jeffwidman
approved these changes
Mar 23, 2020
…nse for future reference
|
Thanks! |
gabriel-tincu
pushed a commit
to aiven/kafka-python
that referenced
this pull request
Sep 22, 2020
This is in preparation for adding `zstd` support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the commit, these need to come all together, as the future code also implements logic that will unpack depending on version. The other PR would then be the ZSTD code itself
This change is